Skip to content

add lettuce db client metrics #13032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 17, 2025
Merged

add lettuce db client metrics #13032

merged 15 commits into from
Jan 17, 2025

Conversation

@zeitlinger
Copy link
Member

Part of #12802

@zeitlinger zeitlinger self-assigned this Jan 13, 2025
@zeitlinger zeitlinger requested a review from a team as a code owner January 13, 2025 13:55
@zeitlinger zeitlinger mentioned this pull request Jan 13, 2025
Closed
4 tasks
@trask
Copy link
Member

trask commented Jan 13, 2025

just in case you didn't notice, looks like CI failures

@zeitlinger
Copy link
Member Author

just in case you didn't notice, looks like CI failures

yeah - just digging up my memory how all this works 😉

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Jan 15, 2025
@zeitlinger
Copy link
Member Author

@steverao please check again

zeitlinger and others added 3 commits January 15, 2025 17:27
@zeitlinger @steverao
Update instrumentation/lettuce/lettuce-5.1/testing/src/main/java/io/o…
02c35cb 
…pentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java

Co-authored-by: Steve Rao <[email protected]>
@zeitlinger
Revert "Update instrumentation/lettuce/lettuce-5.1/testing/src/main/j…
9052b0a 
…ava/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java"

This reverts commit 02c35cb.
@zeitlinger
format
ecc7d61
@zeitlinger
Copy link
Member Author

@jaydeluca fixed 😄

trask
trask approved these changes Jan 16, 2025
View reviewed changes
...src/main/java/io/opentelemetry/instrumentation/testing/junit/db/DbClientMetricsTestUtil.java
Comment on lines +23 to +25
// db.system is required - see
// https://opentelemetry.io/docs/specs/semconv/database/database-metrics/#metric-dbclientoperationduration
assertThat(expectedKeys).extracting(AttributeKey::getKey).contains(DB_SYSTEM.getKey());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit ec26d54 into open-telemetry:main Jan 17, 2025
58 checks passed
@zeitlinger zeitlinger deleted the lettuce-db-client-metric branch January 20, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

@steverao steverao steverao approved these changes

Assignees

@zeitlinger zeitlinger

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zeitlinger @trask @jaydeluca @steverao